when list is embedded in a tab, it sometimes crashes

[sigalalg1]

Thanks for the list code, it's very helpful!

I had a problem while using the list in a tab view. When I tried to move from another tab to this one, sometimes the list crashed in setScrollTop (something like: can't set attribute 'scrollTop' to an undefined object)
Can you add something like:

// set manual scroll top.
setScrollTop: function (scrollTop) {
if (!this.$refs || !this.$refs.vsl)
return;

            this.$refs.vsl.scrollTop = scrollTop
        },

I think that this is also necessary in onScroll

Thanks!

[tangbc]

Thank your report, can you give me vue version and how tab works?

[sigalalg1]

Thanks for the quick response.

We use vue 2.3.3
and vue-electron 1.0.6

The structure which implements the tab view looks like that is skeleton:

• tab1
• tab2

the comp1 code:

this component contain the virtual list

Does it help or you need more information?

[sigalalg1]

tangbc Do you have an estimation when this will be fixed?

[tangbc]

@sigalalg1
I can't reproduce this problem, can you give a example demo link with https://jsfiddle.net ?

[sigalalg1]

We have a complicated page, I am not sure that the problem will be reproduced easily.
On our systems it is reproduced rarely. But when it is, the app is crashing.
I guess that's its a matter of initialization order. refs.vsl is not initialized, and setScrollTop is called.
Isn't it better to add this condition for safety anyway?

[tangbc]

@sigalalg1 Already publish a new version: v.1.2.6.

[sigalalg1]

Thank you!

[sigalalg1]

Hi,
The same problem reproduced in the function onScroll. Is it possible to apply the same fix for this function also?

Thanks

[tangbc]

What's the error info ?

[sigalalg1]

the function onScroll crashed in this line:
var offset = this.$refs.vsl.scrollTop
message from our log:

'TypeError: Cannot read property 'scrollTop' of undefined',
' at i.onScroll

[tangbc]

The best is that you can provide an demo of a stable reproduce, otherwise it's hard to deal with it completely, maybe finish one then case another.

[sigalalg1]

Can't you add a condition before accessing scrollTop? It's safer anyway to check a variable before accessing. A demo is very difficult, since we have a complicated VUE template. I am not sure that after removing our logic the bug will be reproducible.
But a code with safety is better regardless of our problem

[sigalalg1]

We are using electron, with nodejs, so reproducing the issue on a new small environment is problematic