Don't output unparsable arbitrary values #7789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Tailwind CSS detects arbitrary values that use "dynamic-like" placeholders (e.g.
h-[${sizes.height}]) we would still output the CSS. This would result in a rule likeheight: ${sizes.height}which is a syntax error. We were already doing a check to only output rules for arbitrary properties if they result in parsable CSS. I've refactored the code and added a check so we now do the same thing for any arbitrary value and will now skip generating utilities in this case.As a reminder Tailwind CSS does not process your source code and does not generate utilities from dynamic classes which you can read more about here: https://tailwindcss.com/docs/content-configuration#dynamic-class-names
Fixes #7771