Only add ! to selector class matching template candidate
#7664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7226. Before this PR, if you had a class like: ```css .one .two { background: black } ``` ...and then used `!one` in your template, the generated CSS would be this: ```css .\!one .\!two { background: black !important } ``` This would cause the styles to not be applied unless you also added `!` to the beginning of other classes in the template that are part of this selector. This PR makes sure that other classes in the selector aren't mistakenly prefixed with `!`, so that you can add `!` to only one of the classes in your template and get the expected result.
adamwathan
force-pushed
the
import-prefix-multiclass-fix
branch
from
2422b1d to
ab5ff09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7226.
Before this PR, if you had a class like:
...and then used
!onein your template, the generated CSS would be this:This would cause the styles to not be applied unless you also added
!to the beginning of other classes in the template that are part of this selector.This PR makes sure that other classes in the selector aren't mistakenly prefixed with
!, so that you can add!to only one of the classes in your template and get the expected result.