Fix canonicalization of arbitrary variants with attribute selectors #19176
+16
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tailwindlabs/tailwindcss-intellisense#1481
We were detecting when we needed to apply the
*and**variants and even detecting attribute selectors. However we only cleaned up the attribute selectors when they weredata-*oraria-*attributes. This resulted in a "loop" of sorts because we'd:[&_>_[foo]]:flex*variant*variant, giving*:[&_>[foo]]:flexThis then meant that we'd see the
*:[&_>[foo]]:flexthe next time we checked, notice that it still needed a*variant, and repeat…This PR fixes this case to clean up the selector.