Skip to content

Conversation

@philipp-spiess
Copy link
Member

We noticed an issue that the theme() function wourld not properly parse in CSS if you split the argument list over multiple lines. This is fixed by treating \n and \t the same as space:

.custom-font {
  font-family: theme(
    fontFamily.unknown,
    Helvetica Neue,
    Helvetica,
    sans-serif
  );
}

Test plan

Added tests, but also tried it in the Vite example:

Screenshot 2024-11-08 at 13 46 09

@philipp-spiess philipp-spiess requested a review from a team as a code owner November 8, 2024 12:48
@adamwathan adamwathan merged commit aaa32e2 into next Nov 8, 2024
1 check passed
@adamwathan adamwathan deleted the fix/multiline-theme-fn branch November 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants