Fix glob pattern hoisting on Windows #14904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/windows-paths-when-hoisting-globs
branch
from
2b87abe to
7df84f0
Compare
Glob patterns should be in POSIX style, so let's make sure that globs like `../` are handled correctly.
If the incoming absolute path is already absolute, then we don't need to try and resolve it again.
In v3 you can configure `content` to be relative to the `tailwind.config.js` file instead of relative to the current working directory of the process. This ensures that the base is set correctly to the correct base instead.
RobinMalfait
force-pushed
the
fix/windows-paths-when-hoisting-globs
branch
from
7df84f0 to
bab0e72
Compare
No need to normalize the static part because it should already be in POSIX style.
thecrypticace
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures our glob hoisting mechanism (see #14896) works on Windows when performing an upgrade.