Migrate default utilities to have a value suffix #14875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/migrate-shadow-radius-blur-defaults
branch
2 times, most recently
from
5e33444 to
bd34125
Compare
philipp-spiess
approved these changes
Nov 6, 2024
CHANGELOG.md
Outdated
| - _Upgrade (experimental)_: Migrate `grid-cols-[subgrid]` and `grid-rows-[subgrid]` to `grid-cols-subgrid` and `grid-rows-subgrid` ([#14840](https://github.com/tailwindlabs/tailwindcss/pull/14840)) | ||
| - _Upgrade (experimental)_: Rename `grid-cols-[subgrid]` and `grid-rows-[subgrid]` to `grid-cols-subgrid` and `grid-rows-subgrid` ([#14840](https://github.com/tailwindlabs/tailwindcss/pull/14840)) | ||
| - _Upgrade (experimental)_: Support migrating projects with multiple config files ([#14863](https://github.com/tailwindlabs/tailwindcss/pull/14863)) | ||
| - _Upgrade (experimental)_: Rename default utilities (such `shadow`, `blur` and `rounded`) to have a value prefix ([#14875](https://github.com/tailwindlabs/tailwindcss/pull/14875)) |
There was a problem hiding this comment.
"to have a value prefix" isn't clear (also I think you mean suffix here?)
Maybe we can reference the changed section in the changelog here somehow (.. rename shadow, inset-shadow, drop-shadow, rounded, and blur utilities in accordance with the changes made in this version) it's clearer to what we do (or even repeat the exact examples that we have for drop-shdow to drop-shadow-sm etc.
There was a problem hiding this comment.
I did mean suffix, oops. How about this:
There was a problem hiding this comment.
Yeah I think this is the clearest, albeit a bit verbose 👍
There was a problem hiding this comment.
That's exactly what we did in the PR where we introduced these changes, so just used that as a reference. d1724fd
RobinMalfait
changed the title
rounded and blur
This is to ensure that we migrate `blur` to `blur-sm`, and don't migrate again, because then this would be converted to `blur-xs` and that's not what we want.
RobinMalfait
force-pushed
the
feat/migrate-shadow-radius-blur-defaults
branch
from
81606c9 to
caafd6a
Compare
RobinMalfait
added a commit
that referenced
this pull request
Nov 14, 2024
This PR fixes an issue where we migrated classes such as `rounded` to `rounded-sm` (see: #14875) However, if you override the values in your `tailwind.config.js` file, then the migration might not be correct. This PR makes sure to only migrate the classes if you haven't overridden the values in your `tailwind.config.js` file. --------- Co-authored-by: Philipp Spiess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration for migrating the changes we implemented in #14849
This is the migration we perform:
shadowshadow-smshadow-smshadow-xsshadow-xsshadow-2xsinset-shadowinset-shadow-sminset-shadow-sminset-shadow-xsinset-shadow-xsinset-shadow-2xsdrop-shadowdrop-shadow-smdrop-shadow-smdrop-shadow-xsroundedrounded-smrounded-smrounded-xsblurblur-smblur-smblur-xsAlso added an integration test to ensure that
shadowis properly migrated toshadow-sm, and doesn't get migrated toshadow-xs(becauseshadow-smis migrated toshadow-xs).