-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add details about hidden
attribute preflight rules
#2321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small typo. Otherwise LGTM!
src/docs/preflight.mdx
Outdated
} | ||
``` | ||
|
||
This enfoces that elements with a `hidden` attribute stay invisible unless using `hidden="until-found"`. The should *remove* the `hidden` attribute if you want an element to be visible to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The should -> You should
P.S. imo the issue should be converted to a discussion instead of just closed, as there seem to be strong arguments against this breaking change. |
src/docs/preflight.mdx
Outdated
} | ||
``` | ||
|
||
This enfoces that elements with a `hidden` attribute stay invisible unless using `hidden="until-found"`. The should *remove* the `hidden` attribute if you want an element to be visible to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enfoces -> This enforces
Co-authored-by: Nicolas <[email protected]>
In v4 we made a change that makes elements with a hidden attribute
display: none !important
. A consequence of this is that<div hidden class="block">test</div>
will be invisible in v4 where it was visible in v3.The intent is that you must remove this attribute if the element isn't actually meant to be hidden but we didn't document this in the upgrade guide or the preflight page.
Closes tailwindlabs/tailwindcss#18653