Skip to content

use content: none; instead of content: ''; #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021
Merged

use content: none; instead of content: ''; #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d942d16
use `content: none;` instead of `content: '';`
RobinMalfait Jan 8, 2021
d72ecc9
bump dependencies
RobinMalfait Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,19 @@
"@mdx-js/loader": "^1.0.19",
"@mdx-js/mdx": "^1.6.6",
"@next/mdx": "^8.1.0",
"autoprefixer": "^9.6.1",
"autoprefixer": "^10.2.1",
"clean-css": "^4.2.1",
"cssnano": "^4.1.10",
"dedent": "^0.7.0",
"highlight.js": "^10.4.1",
"jest": "^26.6.1",
"next": "^9.4.4",
"postcss": "^7.0.17",
"next": "10",
"postcss": "^8.2.3",
"prettier": "^2.1.2",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"snapshot-diff": "^0.8.1",
"tailwindcss": "^2.0.0-alpha.16"
"tailwindcss": "^2.0.2"
},
"dependencies": {
"lodash.castarray": "^4.4.0",
Expand Down
36 changes: 18 additions & 18 deletions src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ it('should generate the default classes for the typography components', async ()
}

.prose ul > li::before {
content: \\"\\";
content: none;
position: absolute;
background-color: #d1d5db;
border-radius: 50%;
Expand Down Expand Up @@ -199,11 +199,11 @@ it('should generate the default classes for the typography components', async ()
}

.prose pre code::before {
content: \\"\\";
content: none;
}

.prose pre code::after {
content: \\"\\";
content: none;
}

.prose table {
Expand Down Expand Up @@ -1358,7 +1358,7 @@ it('should generate the default classes for the typography components', async ()
}

.sm\\\\:prose ul > li::before {
content: \\"\\";
content: none;
position: absolute;
background-color: #d1d5db;
border-radius: 50%;
Expand Down Expand Up @@ -1483,11 +1483,11 @@ it('should generate the default classes for the typography components', async ()
}

.sm\\\\:prose pre code::before {
content: \\"\\";
content: none;
}

.sm\\\\:prose pre code::after {
content: \\"\\";
content: none;
}

.sm\\\\:prose table {
Expand Down Expand Up @@ -2643,7 +2643,7 @@ it('should generate the default classes for the typography components', async ()
}

.md\\\\:prose ul > li::before {
content: \\"\\";
content: none;
position: absolute;
background-color: #d1d5db;
border-radius: 50%;
Expand Down Expand Up @@ -2768,11 +2768,11 @@ it('should generate the default classes for the typography components', async ()
}

.md\\\\:prose pre code::before {
content: \\"\\";
content: none;
}

.md\\\\:prose pre code::after {
content: \\"\\";
content: none;
}

.md\\\\:prose table {
Expand Down Expand Up @@ -3928,7 +3928,7 @@ it('should generate the default classes for the typography components', async ()
}

.lg\\\\:prose ul > li::before {
content: \\"\\";
content: none;
position: absolute;
background-color: #d1d5db;
border-radius: 50%;
Expand Down Expand Up @@ -4053,11 +4053,11 @@ it('should generate the default classes for the typography components', async ()
}

.lg\\\\:prose pre code::before {
content: \\"\\";
content: none;
}

.lg\\\\:prose pre code::after {
content: \\"\\";
content: none;
}

.lg\\\\:prose table {
Expand Down Expand Up @@ -5213,7 +5213,7 @@ it('should generate the default classes for the typography components', async ()
}

.xl\\\\:prose ul > li::before {
content: \\"\\";
content: none;
position: absolute;
background-color: #d1d5db;
border-radius: 50%;
Expand Down Expand Up @@ -5338,11 +5338,11 @@ it('should generate the default classes for the typography components', async ()
}

.xl\\\\:prose pre code::before {
content: \\"\\";
content: none;
}

.xl\\\\:prose pre code::after {
content: \\"\\";
content: none;
}

.xl\\\\:prose table {
Expand Down Expand Up @@ -6498,7 +6498,7 @@ it('should generate the default classes for the typography components', async ()
}

.\\\\32xl\\\\:prose ul > li::before {
content: \\"\\";
content: none;
position: absolute;
background-color: #d1d5db;
border-radius: 50%;
Expand Down Expand Up @@ -6623,11 +6623,11 @@ it('should generate the default classes for the typography components', async ()
}

.\\\\32xl\\\\:prose pre code::before {
content: \\"\\";
content: none;
}

.\\\\32xl\\\\:prose pre code::after {
content: \\"\\";
content: none;
}

.\\\\32xl\\\\:prose table {
Expand Down
6 changes: 3 additions & 3 deletions src/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = (theme) => ({
position: 'relative',
},
'ul > li::before': {
content: '""',
content: 'none',
position: 'absolute',
backgroundColor: theme('colors.gray.300', defaultTheme.colors.gray[300]),
borderRadius: '50%',
Expand Down Expand Up @@ -112,10 +112,10 @@ module.exports = (theme) => ({
lineHeight: 'inherit',
},
'pre code::before': {
content: '""',
content: 'none',
},
'pre code::after': {
content: '""',
content: 'none',
},
table: {
width: '100%',
Expand Down
Loading