Skip to content

Conversation

@remcohaszing
Copy link
Contributor

It’s nice if npmjs.com links to the repository. :)

@bradlc
Copy link
Contributor

bradlc commented Apr 14, 2022

Thanks @remcohaszing! I don't think I want to add that stuff for tailwindcss-language-service because it isn't really a public module at the moment. If you can revert those two files I will happily merge the tailwindcss-language-server changes 👍

@bradlc
Copy link
Contributor

bradlc commented Apr 19, 2022

Hey @remcohaszing. I hope you don't mind, I made those changes I mentioned so that we can get this merged 💪 Thanks again!

@bradlc bradlc merged commit 97bfbb1 into tailwindlabs:master Apr 19, 2022
@remcohaszing
Copy link
Contributor Author

Sorry for the delay. Of course I don’t mind you made those changes. :)

Although I’d argue that tailwindcss-language-service not being really a public module is actually an argument for saying it’s useful to have a readme, as this way it can be documented it’s not intended for public use. As for the other metadata, I still think it’s useful to link from the package page on npmjs.com to the GitHub repo and don’t see any harm in that.

Regardless, I respect your choice as a maintainer. These changes don’t affect me as an end user anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants