Suggest default variant values when they also support arbitrary values #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
RobinMalfait
approved these changes
Aug 27, 2025
Comment on lines
+1130
to
+1132
| // TODO: This test requires Tailwind CSS v4.1.13 | ||
| // let item2 = items.find((item) => item.label.startsWith('foo-a:')) | ||
| // expect(item2?.detail).toEqual(':is(a)') |
There was a problem hiding this comment.
I'm assuming these tests run against multiple versions?
Can we check the version we are currently running, and enable these tests conditionally?
There was a problem hiding this comment.
They do not… currently. At least not exactly. Each test can define which version it runs against by adding a package.json.
I left these in b/c I want to enable them once we tag a patch.
There was a problem hiding this comment.
Ah, I misunderstood. I had a brainfart and thought it was about v3 vs v4 😅
Yeah that makes sense to enable them once v4.1.13 is released 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following plugin:
We wouldn't suggest
foo:as a variant even though it works. This is because we were suggesting the arbitraryfoo-[]:or the default variant instead of both if a variant supported arbitrary values in v4.This PR fixes the above and now both will be suggested.