Skip to content

Conversation

zargold
Copy link

@zargold zargold commented Oct 2, 2019

is this the correct style of comments desired?

@syntaxseed
Copy link
Owner

syntaxseed commented Oct 2, 2019

I like the jsdoc comments style like so :

/**
* Determines whether first input is the same instanceof second input.
*
* @param {any} left: first-input
* @param {any} right: second-input
* @return {boolean} isInstance: whether first is an instance of second.
*/

But crypto.js is a library I found elsewhere so I have no idea if your comments are correct. Don't worry about commenting that file at this point.

@syntaxseed
Copy link
Owner

Note that PR #13 will be merged before the others once it is fully reviewed. This may need a rebase at that time.

Thanks!

Maybe hold off on any other commenting until then.

@syntaxseed
Copy link
Owner

Please review and rebase this PR, due to a major refactor of the code was recently merged.

Thanks!

@syntaxseed syntaxseed added needs rebase This PR needs a rebase and review, re-test due to divergence from master. invalid This doesn't seem right labels Oct 8, 2019
@zargold zargold closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right needs rebase This PR needs a rebase and review, re-test due to divergence from master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants