Skip to content

Add types #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add types #7

merged 2 commits into from
Oct 28, 2019

Conversation

@ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Oct 26, 2019

// cc @Rokt33r

@ChristianMurphy ChristianMurphy requested a review from a team October 26, 2019 19:19
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Oct 26, 2019
wooorm
wooorm approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@wooorm wooorm changed the title types: add typings for unist-util-select Add types Oct 28, 2019
@wooorm wooorm merged commit 3100da1 into syntax-tree:master Oct 28, 2019
Rokt33r
Rokt33r approved these changes Oct 28, 2019
View reviewed changes
Copy link

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristianMurphy ChristianMurphy deleted the types/add-typings branch October 28, 2019 12:56
@wooorm wooorm added ⛵️ status/released and removed 🙉 open/needs-info This needs some more info labels Dec 1, 2019
@ChristianMurphy ChristianMurphy mentioned this pull request Feb 6, 2020
Closed
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

+1 more reviewer

@Rokt33r Rokt33r Rokt33r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristianMurphy @wooorm @Rokt33r