Add types #3
Add types #3
Conversation
There was a problem hiding this comment.
Thanks @guillaumegarcia13!
It would be good to have a type test for this, similar to https://github.com/stefanprobst/xast-util-sitemap/blob/2a1a85a33cbd5a565f4c7fef7f142160a596bd6d/types/test.ts which was added in syntax-tree/xast-util-sitemap#1
ChristianMurphy
added
☂️ area/types
ChristianMurphy
requested review from
BarryThePenguin,
Murderlon and
remcohaszing
Co-authored-by: Christian Murphy <[email protected]>
Co-authored-by: Christian Murphy <[email protected]>
Co-authored-by: Christian Murphy <[email protected]>
|
Hi @ChristianMurphy! |
There was a problem hiding this comment.
Thanks for following up @guillaumegarcia13! Just a few more tweaks and this should be good to go!
|
Would it be possible to have type tests for this PR? |
Co-authored-by: Christian Murphy <[email protected]>
Co-authored-by: Christian Murphy <[email protected]>
Co-authored-by: Christian Murphy <[email protected]>
Co-authored-by: Christian Murphy <[email protected]>
types/index.d.ts
Outdated
| * @param options Whether to drop parent nodes if they had children, but all their children were filtered out. Default is {cascade: true} | ||
| * @param test is-compatible test (such as a type) | ||
| */ | ||
| export function remove<T extends Node>( |
There was a problem hiding this comment.
This function is exported using module.exports = remove.
To reflect this correctly in the types, this should be exported using:
export = remove
Co-authored-by: Remco Haszing <[email protected]>
|
Thanks all, released in 2.1.0! |
|
Thank you all for your patience and advice. 🙏🏻 |
[Typescript newbie here 👶🏻]
Not too sure about this one... 😬
Would happily be reviewed