Skip to content

Fix typo to expose Options type #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix typo to expose Options type #19

merged 1 commit into from
Sep 25, 2023

Conversation

rwe
Copy link
Contributor

@rwe rwe commented Sep 24, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

The type of Options was exported as the type of the lib/index.js module itself, not the intended Options type.

This fixes that export.

@rwe
fix incorrectly-exported Options type
6900f26 
The type of `Options` was exported as the type of the module.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 24, 2023
@wooorm wooorm changed the title fix incorrectly-exported Options type Fix typo to expose Options type Sep 25, 2023
@wooorm wooorm merged commit 4246be3 into syntax-tree:main Sep 25, 2023
@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Sep 25, 2023
@wooorm
Copy link
Member

wooorm commented Sep 25, 2023

Thanks!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwe @wooorm