Skip to content

Conversation

ChristianMurphy
Copy link
Member

Object.assign is now a native part of JavaScript
object-assign the package can be safely removed on Node and for most browsers (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign)

This reduces the bundled size significantly
Screenshot_2019-10-30 unist-builder 2 0 0 ❘ BundlePhobia

@ChristianMurphy ChristianMurphy added 🌐 platform/browser This affects browsers 📦 area/deps This affects dependencies 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Oct 31, 2019
@wooorm wooorm added the 🧑 semver/major This is a change label Oct 31, 2019
@wooorm
Copy link
Member

wooorm commented Oct 31, 2019

Looks good, but technically a breaking change.
We can sneak it into 2.0.1 maybe though, because the large ecosystem probably hasn’t updated yet.

Related to GH-1

@ChristianMurphy
Copy link
Member Author

I agree technically breaking, though I anticipate it will be low impact since most adopters are using some for of build system, and polyfilling is a piece of most browser build systems, so the migration shouldn't be too difficult.

@wooorm wooorm merged commit 60482b3 into syntax-tree:master Oct 31, 2019
@ChristianMurphy ChristianMurphy deleted the refactor/drop-dependency-on-object-assign branch October 31, 2019 21:44
@wooorm wooorm added ⛵️ status/released and removed 🙉 open/needs-info This needs some more info labels Nov 3, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done 🌐 platform/browser This affects browsers 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

2 participants