Tight mode was failing for heading levels greater than 2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooorm
approved these changes
Dec 20, 2016
This comment has been minimized.
This comment has been minimized.
4 tasks
wooorm
pushed a commit
to remarkjs/remark-toc
that referenced
this pull request
Dec 21, 2016
The failing case is fixed in the `mdast-util-toc` dependency: syntax-tree/mdast-util-toc/pull/3.
wooorm
added
⛵️ status/released
🐛 type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was because the option
tightwasn't passed to all instances ofinsert.We found it when trying to add remark to videojs.
the first commit is a failing test case. The second commit fixes the issue.