feat(users/ignoring): add escaping on Windows #919
Conversation
tomasz1986
changed the title
|
Should the base branch be main or v2? |
|
I don't think we have a v2 branch here? The main PR is against v2, so I created a milestone to collect changes here which should not be merged before v2 becomes the "current" release. |
|
|
Which is the basis for #901, but unrelated to this change here. That's why I added both to the v2 milestone for easily filtering out when the time has come. |
|
@acolomb Should we add a say, in the footer of this note? |
rasa
force-pushed
the
rasa-add-stignore-escaping
branch
from
50763c3 to
6e0f276
Compare
|
Reopening per syncthing/syncthing#10058 (comment) . Should this target main, or https://github.com/syncthing/docs/tree/jb/v2 ? |
Based on the discussion in https://forum.syncthing.net/t/towards-syncthing-2-0/24072/35 This PR adds the ability for Windows users to use the pipe character (|) to escape the metacharacters *, ?, [, and { in .stignore files. Additionally, this PR adds the ability for the user to set the escape character to backslash, or any character they want, by adding a line in the form: #escape=X (where X is any single rune), to the top of an .stignore file. This would allow users to use the same .stignore file across platforms, by simply adding #escape=\ to the top of the file. ### Testing All tests pass in CI. ### Documentation See syncthing/docs#919 Fixes #10057: Support escaping in .stignore files on Windows Fixes #7547: Ignore pattern with \[ and \] does not work
|
Target and merge into |
|
And indeed add a |
|
I switched the target |
Done. |
Ref syncthing/syncthing#10058