Skip to content

Fix nullable typing causing a deprecation in PHP 8.4 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Fix nullable typing causing a deprecation in PHP 8.4 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Form/EventListener/SingleUploadSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function postSubmit(FormEvent $event): void
}
}

private function isFieldSingleUpload(ResolvedFormTypeInterface $formTypeInterface = null): bool
private function isFieldSingleUpload(?ResolvedFormTypeInterface $formTypeInterface = null): bool
{
if ($formTypeInterface == null) {
return false;
Expand Down
2 changes: 1 addition & 1 deletion Storage/FileStorageInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ interface FileStorageInterface
{
public function storeFiles(array $files): array;

public function getFile(string $fileId = null): ?UploadedFile;
public function getFile(?string $fileId = null): ?UploadedFile;
}
4 changes: 2 additions & 2 deletions Storage/LocalFileStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class LocalFileStorage implements FileStorageInterface

private SessionInterface $session;

public function __construct(private readonly RequestStack $requestStack, string $tempDir = null)
public function __construct(private readonly RequestStack $requestStack, ?string $tempDir = null)
{
$this->temporaryDirectory = $tempDir ?: sys_get_temp_dir() . DIRECTORY_SEPARATOR . 's2a' . DIRECTORY_SEPARATOR . 'collectionupload';
}
Expand Down Expand Up @@ -52,7 +52,7 @@ public function storeFiles(array $files): array
return $handledFiles;
}

public function getFile(string $fileId = null): ?UploadedFile
public function getFile(?string $fileId = null): ?UploadedFile
{
if (is_null($fileId)) {
return null;
Expand Down