Honor --public flag given to 'yarn run dev-server ...'

[lyrixx]

I'm using docker (one container for the front, another one for webpack)
and I had to do this PR to make it work.

For reference, this is the command I (docker actually) executed

yarn run dev-server --host 0.0.0.0 --port 9999 --hot --public https://example.com:443 --disable-host-check

[Lyrkan]

Hi @lyrixx,

That's definitely an issue, however we may require a bit more code here.

The example given in the dev-server doc doesn't specify the protocol, so I guess most people will try using that option without it... which breaks the manifest.json/entrypoints.json files.

For instance:

$ yarn encore dev-server --host 0.0.0.0 --port 8080 --public foo.local:80

// manifest.json
{
  "main.css": "foo.local:80/main.css",
  "main.js": "foo.local:80/main.js",
}

// entrypoints.json
{
  "entrypoints": {
    "main": {
      "css": [
        "foo.local:80/main.css"
      ],
      "js": [
        "foo.local:80/main.js"
      ]
    }
  }
}

I guess we should also look if the protocol is present in the value of --public and add it if necessary (there is also the --https option to take into account for that case).

[lyrixx]

Thanks for the review. I updated the PR. Is it better?

[Lyrkan]

Yes, it seems to work perfectly, thank you :)

Just a small thing left to avoid an error when --public isn't followed by a string (argv.public becomes a boolean in that case, so .includes(...) doesn't work).

[weaverryan]

Nice one @lyrixx! Thank you!