Skip to content

Allow entrypoints.json to be hosted remotely #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow entrypoints.json to be hosted remotely #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Asset/EntrypointLookup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,15 @@ private function getEntriesData(): array
}
}

if (!file_exists($this->entrypointJsonPath)) {
$entrypointJsonContents = file_get_contents($this->entrypointJsonPath);
if ($entrypointJsonContents === false) {
if (!$this->strictMode) {
return [];
}
throw new \InvalidArgumentException(sprintf('Could not find the entrypoints file from Webpack: the file "%s" does not exist.', $this->entrypointJsonPath));
throw new \InvalidArgumentException(sprintf('Could not find the entrypoints file from Webpack: the file "%s" does not exist or it is not readable.', $this->entrypointJsonPath));
}

$this->entriesData = json_decode(file_get_contents($this->entrypointJsonPath), true);
$this->entriesData = json_decode($entrypointJsonContents, true);

if (null === $this->entriesData) {
throw new \InvalidArgumentException(sprintf('There was a problem JSON decoding the "%s" file', $this->entrypointJsonPath));
Expand Down