Handle Stimulus CSS Classes #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @weaverryan, would you mind reviewing this PR soon? I'd love to use this feature in my projects. Thanks :) |
weaverryan
reviewed
Oct 18, 2022
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Looks good - can you just tweak that one part in the docs?
|
|
||
| ```twig | ||
| <div {{ stimulus_controller('chart', { 'name': 'Likes', 'data': [1, 2, 3, 4] }) }}> | ||
| <div {{ stimulus_controller('chart', { 'name': 'Likes', 'data': [1, 2, 3, 4] }, { 'loading': 'spinner' }) }}> |
Member
There was a problem hiding this comment.
I think we should leave this example alone, then add a 2nd example below. The reason is that this might make it look like passing CSS values is required or important, whereas in most cases, it wouldn't be used.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review :)
I moved it into a separate example, with & without values.
Contributor
Author
weaverryan
approved these changes
Oct 18, 2022
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Looks good! I'll merge and then we'll make sure tests are passing now that you've fixed them :)
weaverryan
force-pushed
the
stimulus-classes
branch
from
6d045b6 to
6a3b1d4
Compare
Member
|
Thanks @jmsche! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123.
This PR aims to add support for Stimulus CSS Classes (see https://stimulus.hotwired.dev/reference/css-classes).