Skip to content

handle request deprecations #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2021
Merged

handle request deprecations #122

merged 2 commits into from
Apr 24, 2021

Conversation

@jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 23, 2021 •
edited
Loading

  • adds return type declarations where possible
  • handles deprecated HttpEvent::getMasterRequest()

@jrushlow jrushlow force-pushed the fix/master-request branch from 49b4ac9 to 0781d0c Compare April 23, 2021 18:21
@jrushlow jrushlow marked this pull request as ready for review April 23, 2021 18:21
@jrushlow jrushlow mentioned this pull request Apr 23, 2021
Merged
@weaverryan
Copy link
Member

weaverryan commented Apr 24, 2021

Thanks Jesse!

@weaverryan weaverryan merged commit 0269db4 into symfony:main Apr 24, 2021
@jrushlow jrushlow deleted the fix/master-request branch April 26, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrushlow @weaverryan