Allow custom script/link tag attributes to be passed

[weaverryan]

There are a few legit use-cases for wanting to use the encore_entry_script_tags() functions, but pass a custom attribute:

• integrity attribute
• preload, async, etc

Another attribute, in theory, would be adding data- attribute on your script tag. But, that doesn't make sense with encore_entry_script_tags(), because this could render multiple script tags.

I think the main use-cases then are the ones in the list above. And, these might be best integrated (especially integrity) with some global option. I'd like to get use-case feedback and use that to motivate how this is designed.

[dunglas]

It could be nice to be able to integrate encore_entry_script_tags() with the WebLink component too, to allow the use to adk the web server to push the assets when using a HTTP/2 connection.

[nicolas-grekas]

💯 with Kévin!

[alexismarquis]

Having an option for generating absolute urls would be useful as well. In my case I need these for wkhtmltopdf rendering.

[iquito]

A way to just get a list of files would be nice - encore_entry_script_tags() only covers one use case, instead having something like encore_script_files() in Twig which returns an array of files you can then do whatever you want with, and also a service in PHP to get these files, so one can generate script tags in any way needed and (for instance) do preloading or other HTTP things in a controller.

For Content-Security-Policy 3, nonce and strict-dynamic one would also need custom script tags (to add another use case) - a generic way of letting anybody do what they want would be most flexible, because I don't think there is a finite set of use cases you can completely cover when you only offer to specifically generate the script tags (or, for example, specifically add it to WebLink) via the bundle.

[iquito]

Ah I just saw that those already exist - encore_entry_js_files and encore_entry_css_files. Having a clearly visible tutorial on how to use those to generate custom HTML code and also use the service in a controller (or somewhere else) would solve the problem better then having a more complicated encore_entry_script_tags(), in my opinion, but both are of course possible.

Maybe it is also worth mentioning encore_entry_js_files and encore_entry_css_files in the blog article on symfony.com as an alternative to the new syntax, as it is "closer" to the old way of doing it and more flexible. I saw now that it is mentioned in the comments, but not all people might read all the comments or might overlook it.

[stof]

yeah, the 2 functions returning the list of files should be documented, as they allow full flexibility.

[GenieTim]

Additional use case for parameters: the media tag (e.g. media="print")

[weaverryan]

Having an option for generating absolute urls would be useful as well. In my case I need these for wkhtmltopdf rendering.

@alexismarquis you should do this by either setting the public path to an absolute URL in webpack.config.js or setting the framework.assets.base_urls to your absolute URL in framework.yaml. That probably deserves some documentation, even though it's not a new feature.

[alexismarquis]

@weaverryan yeah I thought about that, but this approach would make all asset urls to have an absolute url, which is not something I need for the other templates. Anyway, using the encore_entry_js_files & encore_entry_css_files functions gave me the flexibility I needed (e.g calling absolute_url and preload on each file).

[aarongerig]

@weaverryan Any news on this feature?

Since having the possibility to add integrity hashes to your assets (which is great), it's even more complicated to add custom attributes than before. For example, if I'd wanted to add defer to my script tags, until now I was doing it like so:

{% for file in encore_entry_js_files('entry') %}
    <script src="{{ asset(file) }}" defer></script>
{% endfor %}

But how do you add the integrity hashes now? Is it even possible? As far as I understand, that's only possible using either encore_entry_link_tags() or encore_entry_script_tags().

[ohartl]

As @iquito stated before, it would be nice if we could pass a nonce attribute as that is required for some CSP configurations. I haven't found any possibility to set/override the $defaultAttributes, as the service is private and the class of TagRenderer is final.

Had to do a hack to insert the attribute via {{ encore_entry_script_tags() | replace({'type=': nonce_attr() ~ ' type='}) | raw }}..

[Simperfit]

@weaverryan do you have an ETA for this ? do you need some help ?