[ChartJs] Adding a better way to register Chartjs plugins #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2023
Closed
stof
reviewed
May 12, 2023
src/Chartjs/doc/index.rst
Outdated
| // assets/app.js | ||
| import { Chart } from 'chart.js'; |
src/Chartjs/doc/index.rst
Outdated
| {{ render_chart(chart, {'data-controller': 'mychart'}) }} | ||
| There is also a ``chartjs:init`` event that is called just *one* time before your | ||
| first charts is rendered. That's an ideal place to `register plugins globally <Using Plugins>`_ |
Member
There was a problem hiding this comment.
Suggested change
| first charts is rendered. That's an ideal place to `register plugins globally <Using Plugins>`_ | |
| first chart is rendered. That's an ideal place to `register plugins globally <Using Plugins>`_ |
src/Chartjs/doc/index.rst
Outdated
| // assets/app.js | ||
| import { Chart } from 'chart.js'; |
Member
There was a problem hiding this comment.
This import looks useless to me, as the code snippet does not use it
Member
Author
|
Good catches - thank you Stof! |
weaverryan
force-pushed
the
fix-chartjs-plugin-registeration
branch
from
fc28684 to
ab5f111
Compare
|
Sorry to post this here, but how am I able to fetch this update to my project? And thx @weaverryan for the quick fix! |
Member
Author
|
Change your version in composer.json to 2.x-dev :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method, in npm (and likely in the native browser via importmaps) the Chart would always be imported into the Chartjs UX controller before your userland code would run to register the plugin.
Cheers!