Skip to content

Conversation

@WebMamba
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Tickets
License MIT

see #771

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome start!

@WebMamba
Copy link
Contributor Author

@weaverryan I resolved your comments! And I add a small paragraph for the embedded component 😁

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more notes - looking nice 👍

@weaverryan
Copy link
Member

Thanks Matheo!

@weaverryan weaverryan merged commit 1620116 into symfony:2.x Apr 16, 2023
.. code-block:: html+twig

// "withActions" property will be set to true
<twig:Alert withActions message="hello"></:Alert>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong closing?

<div class="content">
{% block footer %}
...
{% block footer %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be endblock?

{% endblock %}
{% block footer %}
...
{% block footer %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be endblock?

@weaverryan
Copy link
Member

@norkunas there were a few bugs - I hopefully fixed them all in #799

weaverryan added a commit that referenced this pull request Apr 18, 2023
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[Twig] Tweaking docs for new HTML syntax

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Tickets       | None
| License       | MIT

Just following up with a few more tweaks to `@WebMamba`'s docs in #792.

Cheers!

Commits
-------

6691401 [Twig] Tweaking docs for new HTML syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants