Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9bf843b
# This is a combination of 6 commits.
weaverryan Sep 24, 2022
32d4ff3
WIP heavy refactoring to Component
weaverryan Nov 1, 2022
2a22483
initial component child tracking/setup
weaverryan Sep 29, 2022
b1ac91c
client-side implementation of differentiating between data & props
weaverryan Sep 29, 2022
526e570
Adding the fingerprint to the system, but not using it yet
weaverryan Sep 29, 2022
6b7fcd2
Sending childrenFingerprints data to server on Ajax call
weaverryan Sep 29, 2022
e5cc4e0
Starting new child tests
weaverryan Sep 29, 2022
07f8517
Work on child rendering tests
weaverryan Oct 1, 2022
1394883
Reset models when resetting data from server
weaverryan Oct 5, 2022
3ccf783
Abstracting more markup-related thing to the new "driver" + plugin sy…
weaverryan Oct 5, 2022
45bcaf4
removing data-live-id-value in favor of data-live-id - no need for both
weaverryan Oct 6, 2022
321f2e4
Moving more systems into plugins
weaverryan Oct 6, 2022
0c56bc6
Removing todo and other things that will be re-worked later
weaverryan Oct 6, 2022
30619de
Making several component methods return a Promise
weaverryan Oct 7, 2022
e38381e
abstracting last bits of markup out of component
weaverryan Oct 7, 2022
d1076f8
Updating docs for working via JS & making change event always update …
weaverryan Oct 10, 2022
fc4883c
Split backend to data and props
weaverryan Oct 11, 2022
ed462f3
Adding ComponentStack to keep track of currently-rendered components …
weaverryan Oct 13, 2022
297e388
Fixing bug where file paths on the system caused id to not be so dete…
weaverryan Oct 13, 2022
0adcdc3
Adding a fingerprint to child components that is a hash of their "inp…
weaverryan Oct 14, 2022
2ffbd2c
fixing outdated internal reference to before rerender
weaverryan Oct 14, 2022
4909915
Setting childrenFingerprints from request onto MountedComponent
weaverryan Oct 14, 2022
5df34f2
Renaming class that was in a bad directory & new event
weaverryan Oct 14, 2022
9701450
Resetting deterministic id to avoid numbering problems in different p…
weaverryan Oct 17, 2022
fd97102
Fixes various tests
weaverryan Oct 17, 2022
aac55bf
Adding a data-model system for sync'ing data between parent and child…
weaverryan Oct 19, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@
],
"rules": {
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-empty-function": "off"
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/ban-ts-comment": "off",
"quotes": [
"error",
"single"
]
},
"env": {
"browser": true
Expand Down
2 changes: 1 addition & 1 deletion src/Cropperjs/Resources/assets/test/controller.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('CropperjsController', () => {
data-cropperjs-public-url-value="https://symfony.com/logos/symfony_black_02.png"
data-cropperjs-options-value="${dataToJsonAttribute({
viewMode: 1,
dragMode: "move"
dragMode: 'move'
})}"
>
</div>
Expand Down
20 changes: 19 additions & 1 deletion src/LiveComponent/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,25 @@
<input data-model="firstName">
```

- Added the ability to add `data-loading` behavior, which is only activated
- [BEHAVIOR CHANGE] The way that child components re-render when a parent re-renders
has changed, but shouldn't be drastically different. Child components will now
avoid re-rendering if no "input" to the component changed _and_ will maintain
any writable `LiveProp` values after the re-render. Also, the re-render happens
in a separate Ajax call after the parent has finished re-rendering.

- [BEHAVIOR CHANGE] If a model is updated, but the new value is equal to the old
one, a re-render will now be avoided.

- [BC BREAK] The `live:update-model` and `live:render` events are not longer
dispatched. You can now use the "hook" system directly on the `Component` object/

- [BC BREAK] The `LiveComponentHydrator::dehydrate()` method now returns a
`DehydratedComponent` object.

- Added a new JavaScript `Component` object, which is attached to the `__component`
property of all root component elements.

- the ability to add `data-loading` behavior, which is only activated
when a specific **action** is triggered - e.g. `<span data-loading="action(save)|show">Loading</span>`.

- Added the ability to add `data-loading` behavior, which is only activated
Expand Down
Loading