Skip to content

Conversation

@t-richard
Copy link
Contributor

@t-richard t-richard commented Aug 21, 2022

Q A
Bug fix? no
New feature? not really
Tickets None
License MIT

This adds the Vue.js component to ux.symfony.com

Some highlights from this PR:

  • Samples are the same as the react ones, just written in Vue.js 3
  • Used the Vue composition API since it's Vue 3 only and it's the new recommended syntax
  • Used a composer local repository to link to the UX Vue.js component while it's not published on packagist, making this PR usable as is locally
  • Changed the gradient for React to use a color closer to the "React blue"
  • Used a similar gradient with the "Vue.js green"
  • Fixed failing test on the Live component page
Pages screenshots

Homepage

image

Vue.js page

image

Vue.js page with a search

image

Vue.js page with an empty search

image

@tgalopin
Copy link
Contributor

You can rebase now it's merged

@t-richard
Copy link
Contributor Author

Rebased, I will update the PR to use the published version once it's live on packagist.

@weaverryan
Copy link
Member

It's up on packagist now - there's not a release yet, but that's ok - we target 2.x-dev on all the packages anyways.

@t-richard
Copy link
Contributor Author

I saw it was on packagist but didn't realized all packages were required with 2.x-dev.

I'll update this, thanks for the heads up.

@weaverryan weaverryan merged commit 9eb58d9 into symfony:2.x Aug 24, 2022
@weaverryan
Copy link
Member

Check that out https://ux.symfony.com/vue 😎

Thanks Thibault!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants