[LiveComponent] Add a generic LiveCollectionType #324
Conversation
| @@ -0,0 +1,35 @@ | |||
| {%- block live_collection_widget -%} | |||
There was a problem hiding this comment.
I think this should be a different name. Maybe live_collection_form_theme.html.twig?
There was a problem hiding this comment.
I think there should be only one theme per component (and per variant like e.g. bootstrap or tailwind) and not per type, and maybe later we would like to add more blocks for an another type, so I would keep the name. WDYT?
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
I think this is a really cool idea! Let's go for it!
| 'data-action': 'live#action', | ||
| 'data-action-name': 'addCollectionItem(name=' ~ form.vars.full_name ~ ')' | ||
| }) }) }} | ||
| {% endif %} |
There was a problem hiding this comment.
It's funny, #90 adds this at the top of the list, and you have it at the bottom. Nothing will work for everyone, but the bottom I think DOES seem better.
There was a problem hiding this comment.
Best would be probably both places :) saying this from experience when I've implemented this :)
There was a problem hiding this comment.
Let's start with one... but it occurs to me that it may be be useful to configure this easily (e.g. top, bottom or both)
|
What is the difference with this PR? |
|
This requires your entire form be a live component, #90 does not. Basically, if your form already is a live component, just this would be required to add this functionality. |
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
This is really wonderful work ❤️ . We may need more docs to mention that you should customize the live_collection_widget and live_collection_entry_row blocks in order to position the buttons just how you want them. I'm excited to try this in a real project and see how it goes :).
weaverryan
force-pushed
the
live-collection
branch
from
0c42b52 to
b1500fd
Compare
|
Thank you Gábor! |
|
Thank you Ryan! |
5 participants
Hello, this is just a quick draft, extracted from a project, to see if is it interesting enough to include here.
TODO