[TwigComponent][Perf] Remove component dumping from profiler to reduce memory usage #3066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladb
approved these changes
Sep 3, 2025
carsonbot
added
Status: Reviewed
Kocal
approved these changes
Sep 12, 2025
|
So i checked on the project I work on and .... I'm not a big fan of this idea (but not against the idea of not storing the components ... but) Multiple data are only visible here in the profiler... and basic scalar data is not something that would take that much memory (at all). Could you maybe create a repository / share some code (or context) to understand what numver of components (or what amount of inner data) becomes a problem in dev for you ? I'd rather we change profiling and remove an important feature of it only if we have a concrete example to base this choice on.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the component object dumping from the Symfony UX Twig Component profiler to address memory consumption issues.
IMHO, the component dump is not necessary in the profiler as it can be quite verbose and memory-intensive. When detailed component inspection is needed, it's preferable to dump the component manually in the specific context where debugging is required.