Skip to content

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Mar 19, 2025

Q A
Bug fix? no
New feature? no
Docs? yes/no
Issues Fix #...
License MIT

This PR fixes the following broken checks in high-deps:

1) Symfony\UX\TwigComponent\Tests\Integration\ComponentExtensionTest::testComponentWithConflictBetweenPropsFromTemplateAndClass
Failed asserting that exception message 'Cannot define prop "name" in template "components/Conflict.html.twig". Property already defined in component class "Symfony\UX\TwigComponent\Tests\Fixtures\Component\Conflict" in "components/Conflict.html.twig" at line 1.' contains 'Cannot define prop "name" in template "components/Conflict.html.twig". Property already defined in component class "Symfony\UX\TwigComponent\Tests\Fixtures\Component\Conflict".'.

2) Symfony\UX\TwigComponent\Tests\Integration\EmbeddedComponentTest::testAccessingTheHierarchyTooHighThrowsAnException
Failed asserting that exception message 'Key "this" for sequence/mapping with keys "app, __embedded" does not exist in "embedded_component_hierarchy_exception.html.twig" at line 2.' contains 'with keys "app, __embedded" does not exist.'.

https://github.com/symfony/ux/actions/runs/13929938771/job/38984295237

@carsonbot carsonbot added Bug Bug Fix Feature New Feature Status: Needs Review Needs to be reviewed labels Mar 19, 2025
@Kocal Kocal removed Feature New Feature Bug Bug Fix labels Mar 19, 2025
@Kocal Kocal requested review from kbond and smnandre March 20, 2025 08:57
@Kocal Kocal self-assigned this Mar 20, 2025
@kbond kbond force-pushed the fix-ci-twig-component-high-deps branch from e327cef to 11cce99 Compare March 21, 2025 20:14
@kbond
Copy link
Member

kbond commented Mar 21, 2025

Thanks Hugo.

@kbond kbond merged commit ca5793e into symfony:2.x Mar 21, 2025
9 checks passed
@Kocal Kocal deleted the fix-ci-twig-component-high-deps branch March 22, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants