Skip to content

[CI] Refactor some steps in test-app-encore-app job #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

[CI] Refactor some steps in test-app-encore-app job #2614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ jobs:
- name: External, from "npm add"
ux-packages-source: js-packages
steps:
# Setup
- uses: actions/checkout@v4

- run: corepack enable
Expand All @@ -179,12 +178,22 @@ jobs:
run: php .github/build-packages.php
working-directory: ${{ github.workspace }}

# We always install PHP deps because we of the UX Translator, which requires `var/translations` to exists
- uses: ramsey/composer-install@v3
with:
dependency-versions: 'highest'
working-directory: test_apps/encore-app

- if: matrix.ux-packages-source == 'php-vendor'
name: Refresh dependencies from vendor/
working-directory: test_apps/encore-app
run: yarn
env:
YARN_ENABLE_HARDENED_MODE: 0
YARN_ENABLE_IMMUTABLE_INSTALLS: 0

- if: matrix.ux-packages-source == 'js-packages'
name: Install UX JS packages with a JS package manager
working-directory: test_apps/encore-app
run: |
PACKAGES_TO_INSTALL=''
Expand All @@ -195,7 +204,6 @@ jobs:
echo "Installing packages: $PACKAGES_TO_INSTALL"
yarn add --dev $PACKAGES_TO_INSTALL

# Validations
- name: Ensure UX packages are installed from "${{ matrix.ux-packages-source == 'php-vendor' && 'vendor/symfony/ux-...' || '../../../src/**/assets' }}"
working-directory: test_apps/encore-app
run: |
Expand All @@ -215,9 +223,10 @@ jobs:
env:
EXPECTED_PATTERN: ${{ matrix.ux-packages-source == 'php-vendor' && 'file:vendor/symfony/*' || '../../src/*' }}

- name: Run Encore
- name: Run Encore (dev)
working-directory: test_apps/encore-app
run: |
YARN_ENABLE_HARDENED_MODE=0 YARN_ENABLE_IMMUTABLE_INSTALLS=0 yarn || (echo "Unable to install Yarn dependencies" && exit 1)
yarn encore dev || (echo "Unable to build Encore assets (dev)" && exit 1)
yarn encore production || (echo "Unable to build Encore assets (production)" && exit 1)
run: yarn encore dev

- name: Run Encore (prod)
working-directory: test_apps/encore-app
run: yarn encore production
Loading