[Twig][Live] Native attributes #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
native-attributes-1
branch
from
ce4d954 to
53ec97f
Compare
kbond
commented
Jan 31, 2022
Member
Author
Contributor
|
I think this PR is a good idea. |
weaverryan
reviewed
Feb 2, 2022
kbond
force-pushed
the
native-attributes-1
branch
2 times, most recently
from
dfdbb3a to
2bcbc62
Compare
weaverryan
reviewed
Feb 4, 2022
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
I think this is good. It introduces MountedComponent, but that feels ok to me. 👍 for mer personally
kbond
commented
Feb 4, 2022
| $metadata, | ||
| array_merge(['this' => $component], get_object_vars($component)) | ||
| ); | ||
| $event = new PreRenderEvent($mounted, $this->factory->metadataFor($mounted->getName())); |
Member
Author
There was a problem hiding this comment.
Requiring the service here is a bit unfortunate.
kbond
force-pushed
the
native-attributes-1
branch
from
d79f435 to
37acff2
Compare
Member
|
Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for the
HasAttributesTraitthat was introduced in #220. Attributes are now "a thing all component have".ComponentFactory::create()returns a newMountedComponentobject that holds the "mounted" component, attributes and component metadata.LiveComponentHydrator::dehydrate()now accepts an instance ofMountedComponentandLiveComponentHydrator::hydrate()now returns an instance ofMountedComponent.If the component is live, any attributes are dehydrated/hydrated as "readonly" data (they can't be modified by the frontend).
TODO
HasAttributesTrait