Skip to content

Always re-extract formValues in LiveComponent #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Always re-extract formValues in LiveComponent #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/LiveComponent/src/ComponentWithFormTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,7 @@ public function getFormName(): string

public function getFormValues(): array
{
if (null === $this->formValues) {
$this->formValues = $this->extractFormValues($this->getForm());
}
$this->formValues = $this->extractFormValues($this->getForm());
Copy link
Member

@weaverryan weaverryan Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you were able to put together a failing test, that would be awesome. As you know, this change is also in #221 (with a slight difference). But, at the moment, even in that PR, there are no tests covering the problem (i.e. if I revert that change in #221, its tests still pass). So, a test to show off the problem would be 💯

Copy link
Contributor Author

@norkunas norkunas Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lustmored PR covers more cases than mine, so probably It'd be better to leave to put that test in it's PR, so closing this one :)


return $this->formValues;
}
Expand Down