Skip to content

Improve composer.json files #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Improve composer.json files #23

merged 1 commit into from
Dec 7, 2020

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 7, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? no
Tickets -
License -

Removes the config section, and replaces it with:

    "provide": {
        "symfony/ux-component": "1.1"
    },
    "extra": {
        "branch-alias": {
            "dev-main": "1.1-dev"
        },
        "thanks": {
            "name": "symfony/ux",
            "url": "https://github.com/symfony/ux"
        }
    },
    "minimum-stability": "dev"

tgalopin
tgalopin reviewed Dec 7, 2020
View reviewed changes
@tgalopin
Copy link
Contributor

tgalopin commented Dec 7, 2020

Thank you @nicolas-grekas.

@tgalopin tgalopin merged commit b57f3d8 into symfony:main Dec 7, 2020
@nicolas-grekas nicolas-grekas deleted the cjs branch December 7, 2020 17:09
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 7, 2020
Merged
tgalopin added a commit that referenced this pull request Dec 8, 2020
@tgalopin
minor #28 Use "symfony/ux" tag (nicolas-grekas)
7f60f5a 
This PR was merged into the main branch.

Discussion
----------

Use "symfony/ux" tag

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Tickets       | -
| License       | MIT

As advised by @stof in #23 (comment), here's using a tag instead of a "provide" entry.

This should allow:
1. to have flex install packages as ux-components if-and-only-if they have the tag,
2. to help discover ux-related packages by linking to https://packagist.org/?tags=symfony/ux

Commits
-------

2b396a6 Use "symfony/ux" tag
smnandre pushed a commit to smnandre/ux that referenced this pull request Sep 29, 2023
@weaverryan
Merge pull request symfony#23 from weaverryan/ui-tooltips
a18c600 
[TwigUi] Tailwind tooltip!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot left review comments

@stof stof stof left review comments

@lyrixx lyrixx lyrixx approved these changes

+1 more reviewer

@tgalopin tgalopin tgalopin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @tgalopin @fabpot @lyrixx @stof