[Map][Leaflet] Fix marker icon gradients rendering, which can fails on some projects #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
smnandre
approved these changes
Aug 13, 2024
carsonbot
added
Status: Reviewed
Member
|
Thanks Hugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for UX Map, but for the better.
I didn't have this issue at all when working on UX Map implementation (on my "lab" project or on my personal website), but @smnandre got it when working on #2053:
It looks like over-optimizing the SVG through https://jakearchibald.github.io/svgomg/, the
idattributes optimization brokes the rendering. Using anotheridspecific for UX Map fixes the issue: