Skip to content

[TwigComponent] Allow @ prefix in nested attributes #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2024
Merged

[TwigComponent] Allow @ prefix in nested attributes #1966

merged 1 commit into from
Jul 6, 2024

Conversation

@smnandre
Copy link
Member

@smnandre smnandre commented Jul 6, 2024

This was not compiled

<twig foo:@bar="baz" />

Should fix #1960

@smnandre smnandre requested a review from kbond July 6, 2024 07:30
@kbond kbond force-pushed the feat/allow-nested-arobase-attribute-names branch from 64bf498 to 829c84f Compare July 6, 2024 16:40
@kbond
Copy link
Member

kbond commented Jul 6, 2024

Thanks Simon.

@kbond kbond merged commit fa3f0c6 into symfony:2.x Jul 6, 2024
@kbond kbond mentioned this pull request Jul 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbond kbond Awaiting requested review from kbond

Assignees

No one assigned

Labels

Status: Needs Review Needs to be reviewed TwigComponent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smnandre @kbond @carsonbot