Skip to content

[Stimulus] Allow Twig 3.9 #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2024
Merged

[Stimulus] Allow Twig 3.9 #1753

merged 1 commit into from
Apr 18, 2024

Conversation

@smnandre
Copy link
Member

@smnandre smnandre commented Apr 18, 2024

As long Twig or Live component restrict Twig (until we implement yield ready) no need to restrict it here...

... and that would ease IRL tests for Twig&Live :)

@smnandre
[Stimulus] Allow Twig 3.9
156974c 
As long Twig or Live component restrict Twig (until we implement yield ready) no need to restrict it here...

... and that would ease IRL tests for Twig&Live :)
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 18, 2024
@smnandre smnandre mentioned this pull request Apr 18, 2024
Merged
@kbond
Copy link
Member

kbond commented Apr 18, 2024

Thanks Simon.

@kbond kbond merged commit e6b827b into symfony:2.x Apr 18, 2024
kbond added a commit that referenced this pull request Apr 19, 2024
@kbond
minor #1487 [TwigComponent] Twig "use_yield" compatibility (smnandre)
ea5273c 
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[TwigComponent] Twig "use_yield" compatibility

Use YielReady and allow Twig 3.9

Need #1753  to be merged first

Commits
-------

b07d799 [TwigComponent] Twig "use_yield" compatibility
@smnandre smnandre mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Review Needs to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smnandre @kbond @carsonbot