[Site] improvements/fixes #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Apr 17, 2024
| ['class' => 'Terminal_content'], | ||
| new HtmlElement( | ||
| 'pre', | ||
| ['data-controller' => 'code-highlighter'], |
Member
Author
There was a problem hiding this comment.
Would be nice to have a copy button in here but I'll save for a followup PR 😁
WebMamba
reviewed
Apr 17, 2024
Contributor
WebMamba
left a comment
WebMamba
left a comment
There was a problem hiding this comment.
One minor thing:
In one of the translator exemple the progress bar does not appear correctly
| ['class' => 'Terminal_content'], | ||
| new HtmlElement( | ||
| 'pre', | ||
| ['data-controller' => 'code-highlighter'], |
Member
Author
I'm not entirely sure how to fix but it's broken in the live site currently too. Let's save for a followup PR? FYI - it looks correct in FireFox. |
Member
kbond
added a commit
that referenced
this pull request
Apr 19, 2024
This PR was merged into the 2.x branch. Discussion ---------- [Site] Fix input range colors | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #1743 (comment), removing the custom CSS and configuring Bootstrap variables made the `.form-range` displays correctly in both Chrome and Firefox: <img width="1528" alt="image" src="https://github.com/symfony/ux/assets/2103975/0a45fa49-5ff4-4da2-869d-16e875eef20c"> <img width="1433" alt="image" src="https://github.com/symfony/ux/assets/2103975/f2065757-3e27-45e1-9e4f-e471603e9118"> Commits ------- 6879b28 [Site] Fix input range colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
/changelog, the diffs are now rendered nicely: