[TwigComponent] Register safe classes in the configurator #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
requested changes
Mar 5, 2024
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Just missing 1 phpcs detail - but very nice idea!
carsonbot
added
Status: Needs Work
smnandre
force-pushed
the
safe-classes-configurator
branch
from
cd5f46d to
e32adaf
Compare
Member
Author
Good 😅 |
weaverryan
force-pushed
the
safe-classes-configurator
branch
from
2266990 to
186b216
Compare
Member
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(+ some minor CS)