Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

tweak follow symlinks options for consistency #829

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 2, 2015

@Tobion left some good comments in #828. This PR applies his suggestions.

#
# By default, Apache does not evaluate symbolic links if you did not enable this
# feature in your server configuration. Uncomment the following line if you
# install assets as symlinks or if experience problems related to symlinks when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you experience?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

@xabbuh xabbuh force-pushed the follow-symlinks-hint-tweaks branch from bf257d2 to 39d1fd0 Compare July 2, 2015 07:31
@weaverryan
Copy link
Member

👍 @fabpot would this library fall into the "2 core +1's => anyone can merge" category?

@fabpot
Copy link
Member

fabpot commented Jul 15, 2015

@weaverryan Of course. Don't be shy :)

@fabpot
Copy link
Member

fabpot commented Jul 15, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 39d1fd0 into symfony:2.3 Jul 15, 2015
fabpot added a commit that referenced this pull request Jul 15, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

tweak follow symlinks options for consistency

@Tobion left some good comments in #828. This PR applies his suggestions.

Commits
-------

39d1fd0 tweak follow symlinks options for consistency
@xabbuh xabbuh deleted the follow-symlinks-hint-tweaks branch July 16, 2015 05:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants