Skip to content

Add example for Finder::exclude #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2018
Merged

Add example for Finder::exclude #9158

merged 3 commits into from
Jan 29, 2018

Conversation

theofidry
Copy link
Contributor

Follow up of symfony/symfony#25945

javiereguiluz
javiereguiluz reviewed Jan 29, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need to show a full example with the full dir structure. I'd say this behavior is what people would expect, so maybe just mentioning that exclude dirs must be relative to the in() dir would be enough.

@xabbuh xabbuh added this to the 2.7 milestone Jan 29, 2018
theofidry
theofidry commented Jan 29, 2018
View reviewed changes
Copy link
Contributor Author

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, indeed it's better that way 👍

@javiereguiluz
Copy link
Member

Thanks Théo.

@javiereguiluz javiereguiluz merged commit 99b0f7a into symfony:2.7 Jan 29, 2018
javiereguiluz added a commit that referenced this pull request Jan 29, 2018
@javiereguiluz
minor #9158 Add example for Finder::exclude (theofidry, javiereguiluz)
37c76b2 
This PR was merged into the 2.7 branch.

Discussion
----------

Add example for Finder::exclude

Follow up of symfony/symfony#25945

Commits
-------

99b0f7a Reworded the note as a code comment
5e96849 Update finder.rst
9970d42 Add example for Finder::exclude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@theofidry @javiereguiluz @xabbuh @carsonbot