Skip to content

Improve specification explanation #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Improve specification explanation #7601

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2afc79f
Improve specification explanation
matthieu88160 Mar 8, 2017
96d1b84
Minor reword and fixed the line length
javiereguiluz Mar 13, 2017
3302f01
Update expiration.rst
matthieu88160 Mar 13, 2017
29e885c
Update expiration.rst
matthieu88160 Mar 13, 2017
32857d8
Update expiration.rst
matthieu88160 Mar 13, 2017
0d32432
Update expiration.rst
matthieu88160 Mar 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions http_cache/expiration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,12 @@ the lifetime calculation vulnerable to clock skew. Another limitation
of the ``Expires`` header is that the specification states that "HTTP/1.1
servers should not send ``Expires`` dates more than one year in the future."

.. note::

Accordingly with `RFC 7234 - Caching`_, the ``Expires`` header value is
ignored when a ``s-max-age`` or ``max-age`` header is defined.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, s-maxage (note the missing second dash) and max-age are not headers, but are directives of the Cache-Control header.



.. _`expiration model`: http://tools.ietf.org/html/rfc2616#section-13.2
.. _`FrameworkExtraBundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/cache.html
.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this a deep link to https://tools.ietf.org/html/rfc7234#section-5.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, maybe that's not the best idea as https://tools.ietf.org/html/rfc7234#section-4.2.1 also contains information about the process that must be applied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the process is well explained in section 4.2.1