Skip to content

Conversation

giosh94mhz
Copy link
Contributor

The current documentation for group_sequence_provider option in the docs is wrong.
It states that the option should be set with:

Your\Class\Name:
    group_sequence_provider: ~
    ...

But this didn't work.

By looking at the unit test I came up the the right version:

Your\Class\Name:
    group_sequence_provider: true
    ...

@wouterj
Copy link
Member

wouterj commented Aug 24, 2014

Indeed, anything but null is allowed as a value (since they use isset() in the code). But let's use true! (it's the most logical)

thanks for investigating this bug!

@weaverryan
Copy link
Member

Beautiful - thanks @giosh94mhz!

@weaverryan weaverryan merged commit 81cec5d into symfony:2.3 Aug 25, 2014
weaverryan added a commit that referenced this pull request Aug 25, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fix documentation for group_sequence_provider

The current documentation for `group_sequence_provider` option in the docs is wrong.
It states that the option should be set with:
```YAML
Your\Class\Name:
    group_sequence_provider: ~
    ...
````
But this didn't work.

By looking at the unit test I came up the the right version:
```YAML
Your\Class\Name:
    group_sequence_provider: true
    ...
````

Commits
-------

81cec5d Fix documentation for group_sequence_provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants