Skip to content

[Validator] Change return type from iterable to Generator #19045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Validator] Change return type from iterable to Generator #19045

merged 1 commit into from
Oct 31, 2023

Conversation

momito69
Copy link
Contributor

As a Generator can introduce some specific code path and behavior, I recommend using this type to be clearer about the provider intent.

@momito69 momito69 requested a review from xabbuh as a code owner October 19, 2023 09:08
@carsonbot carsonbot added this to the 5.4 milestone Oct 19, 2023
@OskarStark
Copy link
Contributor

OskarStark commented Oct 31, 2023 •
edited
Loading

Thank you @momito69 and congrats on your first contribution to the Symfony documentation 👏 🎉

@OskarStark OskarStark merged commit 28b86de into symfony:5.4 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

1 more reviewer

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@momito69 @OskarStark @alexandre-daubois @carsonbot