Skip to content

[Console] Remove occurrences of $defaultName and $defaultDescription #18473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

[Console] Remove occurrences of $defaultName and $defaultDescription #18473

merged 1 commit into from
Jul 3, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #18472

@carsonbot carsonbot added this to the 7.0 milestone Jun 30, 2023
@javiereguiluz
Copy link
Member

I like this ... but maybe we should update first the previous versions to mark these two properties as deprecated?

@alexandre-daubois
Copy link
Member Author

Yes! Done here 🙂 #18474

@javiereguiluz javiereguiluz merged commit 189d0c9 into symfony:7.0 Jul 3, 2023
@javiereguiluz
Copy link
Member

Thanks a lot Alex!

While merging into 7.0 I didn't remove the deprecated directives that you added in #18474. Instead, let's do that as part of the global #18448 PR. Thanks.

@alexandre-daubois
Copy link
Member Author

Got it, thanks! 👌

@javiereguiluz javiereguiluz mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@94noni 94noni 94noni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Console Status: Reviewed

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexandre-daubois @javiereguiluz @94noni @carsonbot