Skip to content

Remove all 6.x versionadded on 7.0 #18449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2023
Merged

Remove all 6.x versionadded on 7.0 #18449

merged 1 commit into from
Oct 16, 2023

Conversation

alexandre-daubois
Copy link
Member

😊

@carsonbot carsonbot added this to the 7.0 milestone Jun 22, 2023
@OskarStark
Copy link
Contributor

I would keep this PR on hold and only do this change close to a 7.0 release because we have a lot of merge conflicts with no reason in between

@OskarStark OskarStark mentioned this pull request Jun 22, 2023
Merged
@alexandre-daubois
Copy link
Member Author

@OskarStark alright got it, thanks!

@alexandre-daubois alexandre-daubois force-pushed the remove-versionadded branch 2 times, most recently from f63e279 to fc2d018 Compare October 16, 2023 08:53
@alexandre-daubois
Copy link
Member Author

I rebased on 7.0. As feature freeze is now here, I think it's safe to update this PR now 🙂

@OskarStark
Copy link
Contributor

Please update .doctor-rst.yaml file too

@alexandre-daubois
Copy link
Member Author

Here you go :)

@OskarStark
Copy link
Contributor

Thank you Alexandre.

@OskarStark OskarStark merged commit 37d9f2f into symfony:7.0 Oct 16, 2023
@alexandre-daubois alexandre-daubois deleted the remove-versionadded branch October 16, 2023 11:59
@javiereguiluz
Copy link
Member

Alex, thanks a lot for taking the time to do all these changes ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @OskarStark @javiereguiluz @carsonbot