[symfony/ux-autocomplete] Adding UX autocomplete recipe #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
weaverryan
added a commit
to symfony/ux
that referenced
this pull request
Jun 9, 2022
… (weaverryan) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Autocompleter] New Ajax-powered, autocomplete component | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Tickets | none | License | MIT Hi! A new component! One I've wanted for a LONG time. In short, it creates things that look like this, where the autocomplete search is backed by Ajax.  Big thanks to EasyAdmin, whose AssociationField heavily inspired this. * [ ] We could possibly avoid the requirement of creating a separate class for Ajax autocomplete by using signed URLs. However, this would only work for "simpler" fields - e.g. if you had a custom `query_builder` (or perhaps other options that we might not want to include in the URL, like `security`), then you would still be required to have the extra class. It's something to explore. Cheers! Recipe: symfony/recipes#1094 Commits ------- 1228e99 [Autocompleter] New Ajax-powered, autocomplete component
weaverryan
changed the title
weaverryan
force-pushed
the
autocomplete-recipe
branch
from
43b65b8 to
34455a6
Compare
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Member
Author
|
This is ready. The QA fails because the CI ALWAYS tests with PHP 7.4... and this is a PHP 8 package only. I'm not sure what we should do about that. |
kbond
approved these changes
Jun 13, 2022
fabpot
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This adds a recipe for the proposed new ux-autocomplete package... the only needed thing is the route import.
Cheers!