make it possible to use multiple to_email in XML #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2014
|
Can you add a test covering the configuration of multiple recipient emails in XML and YAML to avoid regressions here ? |
The Configuration class allows to configure more than one recipient. Since the to_email field was configured with XML configurations as an attribute couldn't be specified multiple times.
|
@stof Added tests for it. |
|
Thanks for fixing this bug @xabbuh. |
stof
added a commit
that referenced
this pull request
Aug 18, 2014
This PR was merged into the 2.1.x-dev branch. Discussion ---------- make it possible to use multiple to_email in XML The Configuration class allows to configure more than one recipient (see symfony/symfony-docs#4135). Since the ``to_email`` field was configured as an attribute in XML configurations, it couldn't be specified multiple times. Commits ------- 44505b6 make it possible to use multiple to_email in XML
|
Cheers! Thanks for merging @stof. |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 25, 2014
… configs (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Logging] document multiple recipients in XML configs | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/monolog-bundle#91) | Applies to | all | Fixed tickets | #3940, #4135 Commits ------- 37ab23d document multiple recipients in XML configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Configuration class allows to configure more than one recipient (see symfony/symfony-docs#4135). Since the
to_emailfield was configured as an attribute in XML configurations, it couldn't be specified multiple times.