[SwiftMailer] send error log mails from CLI #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arodiss
changed the title
| @@ -341,6 +341,7 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler | |||
| if (!$oldHandler) { | |||
| $this->swiftMailerHandlers[] = $handlerId; | |||
| $definition->addTag('kernel.event_listener', array('event' => 'kernel.terminate', 'method' => 'onKernelTerminate')); | |||
| $definition->addTag('kernel.event_listener', array('event' => 'console.terminate', 'method' => 'onCliTerminate')); | |||
There was a problem hiding this comment.
This should be wrapped in a if (method_exists($newHandlerClass, 'onCliTerminate')) to make sure the symfony version is recent enough.
There was a problem hiding this comment.
@Seldaek
right you are
Updated code and set BC break to no
|
Alright thanks, I'll merge whenever it gets merged in symfony, in case something would change in the meantime. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 26, 2014
…m CLI (arodiss) This PR was merged into the 2.5-dev branch. Discussion ---------- [SwiftMailer] [MonologBundle] send error log mails from CLI | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Given I have symfony2 application with Monolog configured to send mail on error logs. When I have exception thrown from CLI task Then I should receive error mail However this is not true because `Monolog/SwiftMailerHandler` is doing force flush only on `kernel.terminate`, but not on `console.terminate` This PR fixes issue together with symfony/monolog-bundle#73 Commits ------- 9bb602f added explicit swiftmailer flush after ConsoleEvents::TERMINATE
|
@Seldaek |
Seldaek
added a commit
that referenced
this pull request
Mar 26, 2014
[SwiftMailer] send error log mails from CLI
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given I have symfony2 application with Monolog configured to send mail on error logs.
When I have exception thrown from CLI task
Then I should receive error mail
However this is not true because
Monolog/SwiftMailerHandleris doing force flush only onkernel.terminate, but not onconsole.terminateThis PR fixes issue together with symfony/symfony#10534